Re: [PATCH 3/3] Ensure that scsi_target_unblock() examines all devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Bart,

[auto build test WARNING on scsi/for-next]
[also build test WARNING on v4.11-rc2 next-20170310]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Bart-Van-Assche/Unblock-SCSI-devices-even-if-the-LLD-is-being-unloaded/20170318-214016
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next
reproduce: make htmldocs

All warnings (new ones prefixed by >>):

   drivers/scsi/scsi.c:669: warning: No description found for parameter 'sdev'
   drivers/scsi/scsi.c:679: warning: No description found for parameter 'sdev'
>> drivers/scsi/scsi_lib.c:3087: warning: No description found for parameter 'dev'
>> drivers/scsi/scsi_lib.c:3087: warning: No description found for parameter 'data'
   drivers/scsi/constants.c:1: warning: no structured comments found

vim +/dev +3087 drivers/scsi/scsi_lib.c

5d9fb5cc1 Mike Christie   2012-05-17  3071  	scsi_internal_device_unblock(sdev, *(enum scsi_device_state *)data);
^1da177e4 Linus Torvalds  2005-04-16  3072  }
^1da177e4 Linus Torvalds  2005-04-16  3073  
ae188a841 Bart Van Assche 2017-03-16  3074  /**
ae188a841 Bart Van Assche 2017-03-16  3075   * target_unblock() - unblock all devices associated with a SCSI target
ae188a841 Bart Van Assche 2017-03-16  3076   *
ae188a841 Bart Van Assche 2017-03-16  3077   * Notes:
ae188a841 Bart Van Assche 2017-03-16  3078   * - Do not use scsi_device_get() nor any of the macros that use this
ae188a841 Bart Van Assche 2017-03-16  3079   *   function from inside scsi_target_block() because otherwise this function
ae188a841 Bart Van Assche 2017-03-16  3080   *   won't have any effect when called while the SCSI LLD is being unloaded.
ae188a841 Bart Van Assche 2017-03-16  3081   * - Do not hold the host lock around the device_unblock() calls because at
ae188a841 Bart Van Assche 2017-03-16  3082   *   least for blk-sq the block layer queue lock is the outer lock and the
ae188a841 Bart Van Assche 2017-03-16  3083   *   SCSI host lock is the inner lock.
ae188a841 Bart Van Assche 2017-03-16  3084   */
^1da177e4 Linus Torvalds  2005-04-16  3085  static int
^1da177e4 Linus Torvalds  2005-04-16  3086  target_unblock(struct device *dev, void *data)
^1da177e4 Linus Torvalds  2005-04-16 @3087  {
^1da177e4 Linus Torvalds  2005-04-16  3088  	if (scsi_is_target_device(dev))
ae188a841 Bart Van Assche 2017-03-16  3089  		starget_for_all_devices(to_scsi_target(dev), data,
^1da177e4 Linus Torvalds  2005-04-16  3090  					device_unblock);
^1da177e4 Linus Torvalds  2005-04-16  3091  	return 0;
^1da177e4 Linus Torvalds  2005-04-16  3092  }
^1da177e4 Linus Torvalds  2005-04-16  3093  
ae188a841 Bart Van Assche 2017-03-16  3094  /**
ae188a841 Bart Van Assche 2017-03-16  3095   * scsi_target_unblock() - unblock all devices associated with a SCSI target

:::::: The code at line 3087 was first introduced by commit
:::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2

:::::: TO: Linus Torvalds <torvalds@xxxxxxxxxxxxxxx>
:::::: CC: Linus Torvalds <torvalds@xxxxxxxxxxxxxxx>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux