On Wed, Mar 08, 2017 at 09:29:28PM +0530, Kashyap Desai wrote: > Thanks Chris. It is understood to have sanity in driver, but how critical > such checks where SG_IO type interface send pass-through request. ? > Are you suggesting as good to have sanity or very important as there may > be a real-time exposure other than SG_IO interface ? I am confused over > must or good to have check. > Also one more fault I can generate using below sg_raw command - SCSI _devices_ need to sanity check any input and fail commands instead of crashing or causing other problems. Normal SCSI HBA drivers don't need to do that as they don't interpret CDBs. Megaraid (and a few other raid drivers) are special in that they take on part of the device functionality and do interpret CDBs sometimes. In that case you'll need to do all that sanity checking and generate proper errors. It would be nice to have come common helpers for this shared between everyone interpreting SCSI CBD (e.g. the SCSI target code, the NVMe SCSI emulation and the various RAID drivers).
