> -----Original Message----- > From: Colin King [mailto:colin.king@xxxxxxxxxxxxx] > Sent: Friday, February 24, 2017 7:44 AM > To: dl-esc-Aacraid Linux Driver; James E . J . Bottomley; Martin K . > Petersen; linux-scsi@xxxxxxxxxxxxxxx > Cc: kernel-janitors@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx > Subject: [PATCH] scsi: aacraid: remove redundant zero check on ret > > From: Colin Ian King <colin.king@xxxxxxxxxxxxx> > > The check for ret being zero is redundant as a few statements earlier we > break out of the while loop if ret is non-zero. Thus we can remove the > zero check and also the dead-code non-zero case too. > > Detected by CoverityScan, CID#1411632 ("Logically Dead Code") > > Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx> > --- > drivers/scsi/aacraid/commsup.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) Acked-by: Dave Carroll <david.carroll@xxxxxxxxxxxxx>
