RE: [PATCH] scsi: aacraid: remove redundant zero check on ret

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> -----Original Message-----
> From: Colin King [mailto:colin.king@xxxxxxxxxxxxx]
> Sent: Friday, February 24, 2017 7:44 AM
> To: dl-esc-Aacraid Linux Driver; James E . J . Bottomley; Martin K .
> Petersen; linux-scsi@xxxxxxxxxxxxxxx
> Cc: kernel-janitors@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: [PATCH] scsi: aacraid: remove redundant zero check on ret
> 
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> 
> The check for ret being zero is redundant as a few statements earlier we
> break out of the while loop if ret is non-zero.  Thus we can remove the
> zero check and also the dead-code non-zero case too.
> 
> Detected by CoverityScan, CID#1411632 ("Logically Dead Code")
> 
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> ---
>  drivers/scsi/aacraid/commsup.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)

Acked-by: Dave Carroll <david.carroll@xxxxxxxxxxxxx>




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux