> -----Original Message----- > From: Johannes Thumshirn [mailto:jthumshirn@xxxxxxx] > Sent: Wednesday, February 15, 2017 12:49 AM > To: Raghava Aditya Renukunta > <RaghavaAditya.Renukunta@xxxxxxxxxxxxx>; jejb@xxxxxxxxxxxxxxxxxx; > martin.petersen@xxxxxxxxxx; linux-scsi@xxxxxxxxxxxxxxx > Cc: Dave Carroll <david.carroll@xxxxxxxxxxxxx>; Gana Sridaran > <gana.sridaran@xxxxxxxxxxxxx>; Scott Benesh > <scott.benesh@xxxxxxxxxxxxx>; dan.carpenter@xxxxxxxxxx > Subject: Re: [PATCH 12/16] aacraid: Skip IOP reset on controller panic(SMART > Family) > > EXTERNAL EMAIL > > > On 02/14/2017 09:44 PM, Raghava Aditya Renukunta wrote: > > When the SMART family of controller panic (KERNEL_PANIC) , they do not > ^ controllers? ^ extra space > > honor IOP resets. So better to skip it and directly perform a IWBR reset. > > > > Signed-off-by: Raghava Aditya Renukunta > <RaghavaAditya.Renukunta@xxxxxxxxxxxxx> > > Reviewed-by: David Carroll <David.Carroll@xxxxxxxxxxxxx> > > --- > > drivers/scsi/aacraid/src.c | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/drivers/scsi/aacraid/src.c b/drivers/scsi/aacraid/src.c > > index b23c818..5bb9865 100644 > > --- a/drivers/scsi/aacraid/src.c > > +++ b/drivers/scsi/aacraid/src.c > > @@ -714,6 +714,12 @@ static int aac_src_restart_adapter(struct aac_dev > *dev, int bled, u8 reset_type) > > pr_err("%s%d: adapter kernel panic'd %x.\n", > > dev->name, dev->id, bled); > > > > + /* > > + * WHen there is a BlinkLED, IOP_RESET has not effect > ^ When > > + */ > > + if (bled >= 2 && dev->sa_firmware && (reset_type & HW_IOP_RESET)) > ^ No need for the > parenthesis > > + reset_type &= ~HW_IOP_RESET; > > + > > dev->a_ops.adapter_enable_int = aac_src_disable_interrupt; > > > > switch (reset_type) { > > > > Apart from that, > Reviewed-by: Johannes Thumshirn <jthumshirn@xxxxxxx> Yes I will fix this in the next patch set. Regards, Raghava Aditya > -- > Johannes Thumshirn Storage > jthumshirn@xxxxxxx +49 911 74053 689 > SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg > GF: Felix Imendörffer, Jane Smithard, Graham Norton > HRB 21284 (AG Nürnberg) > Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
