On 02/10/2017 10:51 AM, David Miller wrote: > From: Kalle Valo <kvalo@xxxxxxxxxxxxxx> > Date: Thu, 09 Feb 2017 16:10:06 +0200 > >> Florian Fainelli <f.fainelli@xxxxxxxxx> writes: >> >>>>> If not, for something like this it's a must: >>>>> >>>>> drivers/net/wireless/ath/wil6210/cfg80211.c:24:30: error: expected ‘)’ before ‘bool’ >>>>> module_param(disable_ap_sme, bool, 0444); >>>>> ^ >>>>> drivers/net/wireless/ath/wil6210/cfg80211.c:25:34: error: expected ‘)’ before string constant >>>>> MODULE_PARM_DESC(disable_ap_sme, " let user space handle AP mode SME"); >>>>> ^ >>>>> Like like that file needs linux/module.h included. >>>> >>>> Johannes already fixed a similar (or same) problem in my tree: >>>> >>>> wil6210: include moduleparam.h >>>> >>>> https://git.kernel.org/cgit/linux/kernel/git/kvalo/wireless-drivers-next.git/commit/?id=949c2d0096753d518ef6e0bd8418c8086747196b >>>> >>>> I'm planning to send you a pull request tomorrow which contains that >>>> one. >>> >>> Thanks Kalle! >>> >>> David, can you hold on this series until Kalle's pull request gets >>> submitted? Past this error, allmodconfig builds fine with this patch >>> series (just tested). Thanks! >> >> Just submitted the pull request: >> >> https://patchwork.ozlabs.org/patch/726133/ > > I've retried this patch series, and will push it out assuming the build > completes properly. I see it merged in net-next/master, thanks a lot this is going to save a lot of cycles in the future, thanks David! -- Florian
