>>>>> "Steffen" == Steffen Maier <maier@xxxxxxxxxxxxxxxxxx> writes: Steffen> Rather than relying on req being NULL (or ERR_PTR) for all Steffen> cases where we don't want to trace or should not trace, simply Steffen> check retval which is unconditionally initialized with -EIO != Steffen> 0 and it can only become 0 on successful retval = Steffen> zfcp_fsf_req_send(req). With that we can also remove the then Steffen> again unnecessary unconditional initialization of req which was Steffen> introduced with that earlier commit. Applied to 4.10/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering