On 2/8/17, 10:42 AM, "Bart Van Assche" <Bart.VanAssche@xxxxxxxxxxx> wrote: >The above code occurs two times in this patch. We try to avoid duplicating >code in the Linux kernel, especially code that contains hardcoded constants. >Have you considered to change the name of plogi_nack_done_jiff into e.g. >plogi_done_deadline and to assign jiffies + HZ to that variable instead of >jiffies? Thanks for the review. Will update patch and resend series.
