Re: [PATCH v2 03/14] qla2xxx: Allow vref count to timeout on vport delete.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2/8/17, 5:03 AM, "Christoph Hellwig" <hch@xxxxxxxxxxxxx> wrote:

>On Fri, Feb 03, 2017 at 02:40:44PM -0800, Himanshu Madhani wrote:
>> -	spin_lock_irqsave(&ha->vport_slock, flags);
>> -	while (atomic_read(&vha->vref_count)) {
>> -		spin_unlock_irqrestore(&ha->vport_slock, flags);
>> -
>> +	while (count-- && atomic_read(&vha->vref_count))
>>  		msleep(500);
>
>Please add a wait queue to skeep on while waiting for vref_count to
>drop to zero.  

Thanks for the review. Will update patch and resend series.




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux