On 02/07/2017 04:40 PM, Christoph Hellwig wrote: > On Tue, Feb 07, 2017 at 04:39:01PM +0100, Hannes Reinecke wrote: >> But we do; we're getting the index/tag/smid from the high-priority list, >> which is separated from the normal SCSI I/O tag space. >> (which reminds me; there's another cleanup patch to be had in >> _ctl_do_mpt_command(), but that's beside the point). > > The calls to blk_mq_tagset_busy_iter added in patch 8 indicate the > contrary. > Right. Now I see what you mean. We should have used reserved_tags here. Sadly we still don't have an interface on actually _allocate_ reserved tags, have we? Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@xxxxxxx +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)