On Tue, Jan 31, 2017 at 02:46:19PM +0100, Hannes Reinecke wrote: > Yes, they are with your latest patchset. No, this has been the case since blk-mq support wa added to scsi. > Yes, but scsi_host_find_tag() still relies on req->special, which it > really shouldn't after your patches; scsi_cmd_priv() should be used there. Both are perfectly fine for now. > > I think this function just needs to go away instantly. > > Trying to send task management requests from userspace for any > > active smid is plain dangerous. > > > Hey, I didn't to it. I just did the conversion. > > But indeed, it's of questionable value. > > I can remove it with the next iteration. I think we need to sort out the mpt-specific passthrough ioctls one way or another. A lot of the mess in this patch comes from the fact that no all I/O goes through the block/scsi layer. Once that is sorted out things become a lot simpler. > So, I'm happy to rebase it on top of your BLOCK_PC changes. Just tell me > which tree to use. You don't need them. cmd_size has been there for a long time for SCSI. The only thing my patches do is to add support to legacy block code and use that new simpler and more efficient implementation in SCSI instead of the old hown-grown implementation in SCSI. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
