RE: [PATCH] storvsc: remove bogus code to transfer struct scatterlist

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> -----Original Message-----
> From: Christoph Hellwig [mailto:hch@xxxxxx]
> Sent: Sunday, January 29, 2017 1:12 AM
> To: KY Srinivasan <kys@xxxxxxxxxxxxx>; Haiyang Zhang
> <haiyangz@xxxxxxxxxxxxx>; Stephen Hemminger
> <sthemmin@xxxxxxxxxxxxx>
> Cc: linux-scsi@xxxxxxxxxxxxxxx
> Subject: [PATCH] storvsc: remove bogus code to transfer struct scatterlist
> 
> Remove a piece of code in storvsc_queuecommand that tries to pass the
> physical address of the kernel struct scatterlist pointer to the host.
> 
> Fortunately the code can't ever be reached anyway.

Thanks Christoph.

Reviewed-by: K. Y. Srinivasan <kys@xxxxxxxxxxxxx>

K. Y

> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> ---
>  drivers/scsi/storvsc_drv.c | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
> index 05526b7..62f4545 100644
> --- a/drivers/scsi/storvsc_drv.c
> +++ b/drivers/scsi/storvsc_drv.c
> @@ -1511,13 +1511,6 @@ static int storvsc_queuecommand(struct Scsi_Host
> *host, struct scsi_cmnd *scmnd)
>  				page_to_pfn(sg_page((cur_sgl)));
>  			cur_sgl = sg_next(cur_sgl);
>  		}
> -
> -	} else if (scsi_sglist(scmnd)) {
> -		payload->range.len = length;
> -		payload->range.offset =
> -			virt_to_phys(scsi_sglist(scmnd)) & (PAGE_SIZE-1);
> -		payload->range.pfn_array[0] =
> -			virt_to_phys(scsi_sglist(scmnd)) >> PAGE_SHIFT;
>  	}
> 
>  	cmd_request->payload = payload;
> --
> 2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux