> -----Original Message----- > From: Johannes Thumshirn [mailto:jthumshirn@xxxxxxx] > Sent: Friday, January 27, 2017 12:08 AM > To: Raghava Aditya Renukunta > <RaghavaAditya.Renukunta@xxxxxxxxxxxxx> > Cc: jejb@xxxxxxxxxxxxxxxxxx; martin.petersen@xxxxxxxxxx; linux- > scsi@xxxxxxxxxxxxxxx; Dave Carroll <david.carroll@xxxxxxxxxxxxx>; Gana > Sridaran <gana.sridaran@xxxxxxxxxxxxx>; Scott Benesh > <scott.benesh@xxxxxxxxxxxxx> > Subject: Re: [PATCH V2 05/24] aacraid: Retrieve and update the device types > > EXTERNAL EMAIL > > > On Thu, Jan 26, 2017 at 09:00:42PM +0000, Raghava Aditya Renukunta wrote: > > > > > > > -----Original Message----- > > > From: linux-scsi-owner@xxxxxxxxxxxxxxx [mailto:linux-scsi- > > > owner@xxxxxxxxxxxxxxx] On Behalf Of Raghava Aditya Renukunta > > > Sent: Thursday, January 26, 2017 10:44 AM > > > To: Johannes Thumshirn <jthumshirn@xxxxxxx> > > > Cc: jejb@xxxxxxxxxxxxxxxxxx; martin.petersen@xxxxxxxxxx; linux- > > > scsi@xxxxxxxxxxxxxxx; Dave Carroll <david.carroll@xxxxxxxxxxxxx>; Gana > > > Sridaran <gana.sridaran@xxxxxxxxxxxxx>; Scott Benesh > > > <scott.benesh@xxxxxxxxxxxxx> > > > Subject: RE: [PATCH V2 05/24] aacraid: Retrieve and update the device > types > > > > > > EXTERNAL EMAIL > > > > > > > > > > -----Original Message----- > > > > From: Johannes Thumshirn [mailto:jthumshirn@xxxxxxx] > > > > Sent: Thursday, January 26, 2017 1:00 AM > > > > To: Raghava Aditya Renukunta > > > > <RaghavaAditya.Renukunta@xxxxxxxxxxxxx> > > > > Cc: jejb@xxxxxxxxxxxxxxxxxx; martin.petersen@xxxxxxxxxx; linux- > > > > scsi@xxxxxxxxxxxxxxx; Dave Carroll <david.carroll@xxxxxxxxxxxxx>; > Gana > > > > Sridaran <gana.sridaran@xxxxxxxxxxxxx>; Scott Benesh > > > > <scott.benesh@xxxxxxxxxxxxx> > > > > Subject: Re: [PATCH V2 05/24] aacraid: Retrieve and update the device > > > types > > > > > > > > EXTERNAL EMAIL > > > > > > > > > > > > On Wed, Jan 25, 2017 at 10:00:52AM -0800, Raghava Aditya Renukunta > > > wrote: > > > > > This patch adds support to retrieve the type of each adapter > connected > > > > > device. Applicable to HBA1000 and SmartIOC2000 products > > > > > > > > > > Signed-off-by: Raghava Aditya Renukunta > > > > <RaghavaAditya.Renukunta@xxxxxxxxxxxxx> > > > > > Signed-off-by: Dave Carroll <David.Carroll@xxxxxxxxxxxxx> > > > > > > > > > > --- > > > > > > > > [...] > > > > > > > > > /* > > > > > * Adapter Information Block > > > > > * > > > > > @@ -1056,7 +1091,28 @@ struct aac_supplement_adapter_info > > > > > /* StructExpansion == 1 */ > > > > > __le32 FeatureBits3; > > > > > __le32 SupportedPerformanceModes; > > > > > - __le32 ReservedForFutureGrowth[80]; > > > > > + u8 HostBusType; /* uses HOST_BUS_TYPE_xxx defines */ > > > > > + u8 HostBusWidth; /* actual width in bits or links */ > > > > > + u16 HostBusSpeed; /* actual bus speed/link rate in MHz */ > > > > > + u8 MaxRRCDrives; /* max. number of ITP-RRC drives/pool > */ > > > > > + u8 MaxDiskXtasks; /* max. possible num of DiskX Tasks */ > > > > > + > > > > > + u8 CpldVerLoaded; > > > > > + u8 CpldVerInFlash; > > > > > + > > > > > + __le64 MaxRRCCapacity; > > > > > + __le32 CompiledMaxHistLogLevel; > > > > > + u8 CustomBoardName[12]; > > > > > + u16 SupportedCntlrMode; /* identify supported controller > mode > > > */ > > > > > + u16 ReservedForFuture16; > > > > > + __le32 SupportedOptions3; /* reserved for future options */ > > > > > + > > > > > + __le16 VirtDeviceBus; /* virt. SCSI device for Thor */ > > > > > + __le16 VirtDeviceTarget; > > > > > + __le16 VirtDeviceLUN; > > > > > + __le16 Unused; > > > > > + __le32 ReservedForFutureGrowth[68]; > > > > > + > > > > > > Same here. > > > > On second thought changing all of the variables here will open up > > Pandoras box. I will leave them as it is for now and change the whole > > structure and anything attached it in one of my next patch submission > series. > > > > Will that be ok? > > Yes that's something I can live with, *iff* it really happens. I plan to make it happen, in the next set of patches that I send. :) Thank you, Raghava Aditya > > -- > Johannes Thumshirn Storage > jthumshirn@xxxxxxx +49 911 74053 689 > SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg > GF: Felix Imendörffer, Jane Smithard, Graham Norton > HRB 21284 (AG Nürnberg) > Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850 -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
