On Tue, 2017-01-24 at 09:09 +0100, hch@xxxxxx wrote: > On Tue, Jan 24, 2017 at 12:33:13AM +0000, Bart Van Assche wrote: > > Do we perhaps need a check before the above memcpy() call whether or not > > sense == NULL? > > Yes, probably. I didn't think of the case where the caller wouldn't > pass a sense buffer. Just curious, what's the callstack that caused > this? Hello Christoph, The call stack was as follows: * __scsi_execute() * scsi_execute_req_flags() * scsi_vpd_inquiry() * scsi_attach_vpd() * scsi_probe_and_add_lun() * __scsi_add_device() * ata_scsi_scan_host() * async_port_probe() * async_run_entry_fn() * process_one_work() * worker_thread() * kthread() Bart.-- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html