Re: [PATCH 17/24] aacraid: Added support to abort cmd and reset lun

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Raghava,

[auto build test WARNING on scsi/for-next]
[also build test WARNING on v4.10-rc5 next-20170123]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Raghava-Aditya-Renukunta/aacraid-Patchset-for-Smart-Family-card-support/20170124-093617
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next
config: x86_64-randconfig-x014-201704 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

Note: it may well be a FALSE warning. FWIW you are at least aware of it now.
http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings

All warnings (new ones prefixed by >>):

   drivers/scsi/aacraid/linit.c: In function 'aac_eh_abort':
>> drivers/scsi/aacraid/linit.c:685:38: warning: 'command' may be used uninitialized in this function [-Wmaybe-uninitialized]
        if ((fib->hw_fib_va->header.XferState &
            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
         cpu_to_le32
         ~~~~~~~~~~~                      
         (Async | NoResponseExpected)) &&
         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 
         (fib->flags & FIB_CONTEXT_FLAG) &&
         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
         ((command == fib->callback_data)) &&
         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

vim +/command +685 drivers/scsi/aacraid/linit.c

03d44337 Mark Haverkamp           2007-03-15  669  			}
b6ef70f3 Salyzyn, Mark            2008-01-08  670  			break;
b6ef70f3 Salyzyn, Mark            2008-01-08  671  		case TEST_UNIT_READY:
1281d604 Raghava Aditya Renukunta 2017-01-23  672  			/*
1281d604 Raghava Aditya Renukunta 2017-01-23  673  			 * Mark associated FIB to not complete,
1281d604 Raghava Aditya Renukunta 2017-01-23  674  			 * eh handler does this
1281d604 Raghava Aditya Renukunta 2017-01-23  675  			 */
1281d604 Raghava Aditya Renukunta 2017-01-23  676  			for (count = 0;
1281d604 Raghava Aditya Renukunta 2017-01-23  677  				count < (host->can_queue + AAC_NUM_MGT_FIB);
1281d604 Raghava Aditya Renukunta 2017-01-23  678  				++count) {
b6ef70f3 Salyzyn, Mark            2008-01-08  679  				struct scsi_cmnd *command;
b6ef70f3 Salyzyn, Mark            2008-01-08  680  				struct fib *fib = &aac->fibs[count];
1281d604 Raghava Aditya Renukunta 2017-01-23  681  
1281d604 Raghava Aditya Renukunta 2017-01-23  682  				if ((fib->hw_fib_va->header.XferState &
1281d604 Raghava Aditya Renukunta 2017-01-23  683  					cpu_to_le32
1281d604 Raghava Aditya Renukunta 2017-01-23  684  					(Async | NoResponseExpected)) &&
b6ef70f3 Salyzyn, Mark            2008-01-08 @685  					(fib->flags & FIB_CONTEXT_FLAG) &&
1281d604 Raghava Aditya Renukunta 2017-01-23  686  					((command == fib->callback_data)) &&
b6ef70f3 Salyzyn, Mark            2008-01-08  687  					(command->device == cmd->device)) {
1281d604 Raghava Aditya Renukunta 2017-01-23  688  					fib->flags |=
1281d604 Raghava Aditya Renukunta 2017-01-23  689  						FIB_CONTEXT_FLAG_TIMED_OUT;
1281d604 Raghava Aditya Renukunta 2017-01-23  690  					command->SCp.phase =
1281d604 Raghava Aditya Renukunta 2017-01-23  691  						AAC_OWNER_ERROR_HANDLER;
b6ef70f3 Salyzyn, Mark            2008-01-08  692  					if (command == cmd)
b6ef70f3 Salyzyn, Mark            2008-01-08  693  						ret = SUCCESS;

:::::: The code at line 685 was first introduced by commit
:::::: b6ef70f33ca2a3084b4fea12414550724a9114dc [SCSI] aacraid: OS panic after Adapter panic (hardening).

:::::: TO: Salyzyn, Mark <Mark_Salyzyn@xxxxxxxxxxx>
:::::: CC: James Bottomley <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux