On 01/19/2017 03:46 PM, Christoph Hellwig wrote: > On Thu, Jan 19, 2017 at 03:17:45PM +0100, Hannes Reinecke wrote: >> When we're hitting a busy condition in queuecommand() we need to >> stop the hardware queue before calling blk_mq_delay_queue(); if >> we don't blk_mq_delay_queue() will not do anything and requeue >> will never triggered. > > I suspect the stop needs to move into blk_mq_delay_queue to make > it more useful. > Which is what I've suggested to Jens, too. And he even agreed to it :-) Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@xxxxxxx +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html