On Tue, Jan 17, 2017 at 07:43:51PM +0530, Sreekanth Reddy wrote: > [Sreekanth] Just for readability purpose, can use use "if (test_bit(0, > &sas_device_priv_data->ata_command_pending)" > instead of "if (sas_device_priv_data->ata_command_pending)". > Since while setting & clearing the bit we are using atomic bit > operations. I don't see any issue functionality wise. I agree. Also while we're into nitpicking - it would be good to give bit 0 of the bitmap a name instead of hardcoding the 0. Except for these patch looks fine: Reviewed-by: Christoph Hellwig <hch@xxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
