>>>>> "Ewan" == Ewan D Milne <emilne@xxxxxxxxxx> writes: Ewan> The call to scsi_is_sas_rphy() needs to be made on the SAS Ewan> end_device, not on the SCSI device. Ewan> Fixes: 835831c57e9b ("ses: use scsi_is_sas_rphy instead of Ewan> is_sas_attached") Reviewed-by: Johannes Thumshirn Ewan> <jthumshirn@xxxxxxx> Signed-off-by: Ewan D. Milne Ewan> <emilne@xxxxxxxxxx> --- Ewan> drivers/scsi/ses.c | 2 +- 1 file changed, 1 insertion(+), 1 Ewan> deletion(-) Ewan> diff --git a/drivers/scsi/ses.c b/drivers/scsi/ses.c index Ewan> 8c9a35c..50adabb 100644 Ewan> --- a/drivers/scsi/ses.c Ewan> +++ b/drivers/scsi/ses.c Ewan> @@ -587,7 +587,7 @@ static void ses_match_to_enclosure(struct Ewan> enclosure_device *edev, Ewan> ses_enclosure_data_process(edev, Ewan> to_scsi_device(edev->edev.parent), 0); Ewan> - if (scsi_is_sas_rphy(&sdev->sdev_gendev)) Ewan> + if (scsi_is_sas_rphy(sdev->sdev_target->dev.parent)) Ewan> efd.addr = sas_get_address(sdev); Ewan> if (efd.addr) { Ewan> -- 1.8.3.1 James? -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html