> -----Original Message----- > From: Hannes Reinecke [mailto:hare@xxxxxxx] > Sent: Thursday, October 27, 2016 4:04 AM > To: Don Brace <don.brace@xxxxxxxxxxxxx>; jejb@xxxxxxxxxxxxxxxxxx; John > Hall <John.Hall@xxxxxxxxxxxxx>; Kevin Barnett > <kevin.barnett@xxxxxxxxxxxxx>; Mahesh Rajashekhara > <mahesh.rajashekhara@xxxxxxxxxxxxx>; hch@xxxxxxxxxxxxx; Scott Teel > <scott.teel@xxxxxxxxxxxxx>; Viswas G <viswas.g@xxxxxxxxxxxxx>; Justin > Lindley <justin.lindley@xxxxxxxxxxxxx>; Scott Benesh > <scott.benesh@xxxxxxxxxxxxx>; elliott@xxxxxxx; POSWALD@xxxxxxxx > Cc: linux-scsi@xxxxxxxxxxxxxxx > Subject: Re: [PATCH 3/4] hpsa: remove coalescing settings for ioaccel2 > > EXTERNAL EMAIL > > > On 10/27/2016 12:21 AM, Don Brace wrote: > > - Setting coalescing has a significant negative > > impact on low queue-depth performance. > > - Does not help high queue-depth performance. > > > > Reviewed-by: Scott Benesh <scott.benesh@xxxxxxxxxxxxx> > > Reviewed-by: Scott Teel <scott.teel@xxxxxxxxxxxxx> > > Reviewed-by: Kevin Barnett <kevin.barnett@xxxxxxxxxxxxx> > > Signed-off-by: Don Brace <don.brace@xxxxxxxxxxxxx> > > --- > > drivers/scsi/hpsa.c | 8 ++------ > > 1 file changed, 2 insertions(+), 6 deletions(-) > > > > diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c > > index 9fb739c..810c300 100644 > > --- a/drivers/scsi/hpsa.c > > +++ b/drivers/scsi/hpsa.c > > @@ -9277,13 +9277,9 @@ static int hpsa_enter_performant_mode(struct > ctlr_info *h, u32 trans_support) > > access = SA5_ioaccel_mode1_access; > > writel(10, &h->cfgtable->HostWrite.CoalIntDelay); > > writel(4, &h->cfgtable->HostWrite.CoalIntCount); > > - } else { > > - if (trans_support & CFGTBL_Trans_io_accel2) { > > + } else > > + if (trans_support & CFGTBL_Trans_io_accel2) > > access = SA5_ioaccel_mode2_access; > > - writel(10, &h->cfgtable->HostWrite.CoalIntDelay); > > - writel(4, &h->cfgtable->HostWrite.CoalIntCount); > > - } > > - } > > writel(CFGTBL_ChangeReq, h->vaddr + SA5_DOORBELL); > > if (hpsa_wait_for_mode_change_ack(h)) { > > dev_err(&h->pdev->dev, > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > > the body of a message to majordomo@xxxxxxxxxxxxxxx > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > > Reviewed-by: Hannes Reinecke <hare@xxxxxxxx> > > Cheers, > > Hannes > -- > Dr. Hannes Reinecke Teamlead Storage & Networking > hare@xxxxxxx +49 911 74053 688 > SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg > GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton > HRB 21284 (AG Nürnberg) Wondering what has happened to this patch? Thanks, Don Brace ESC - Smart Storage Microsemi Corporation ��.n��������+%������w��{.n�����{������ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
