On 12/23/2016 08:23 PM, Himanshu Madhani wrote: > -#define QLA_TGT_MODE_ENABLED() (ql2x_ini_mode != QLA2XXX_INI_MODE_ENABLED) > +#define QLA_TGT_MODE_ENABLED() \ > + ((ql2x_ini_mode != QLA2XXX_INI_MODE_ENABLED) || \ > + (ql2x_ini_mode == QLA2XXX_INI_MODE_DUAL)) Hello Himanshu and Quinn, Is this change needed? It looks redundant to me. For all possible ql2x_ini_mode values both the old and the new expression will yield the same value. Anyway, dual mode is a welcome improvement! Bart. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html