Re: [PATCH 3/4] cxlflash: Cleanup prints

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/01/17 01:05, Uma Krishnan wrote:
From: "Matthew R. Ochs" <mrochs@xxxxxxxxxxxxxxxxxx>

The usage of prints within the cxlflash driver is inconsistent. This
hinders debug and makes the driver source and log output appear sloppy.

The following cleanups help unify the prints within cxlflash:
 - move all prints to dev-* where possible
 - transition all hex prints to lowercase
 - standardize variable prints in debug output
 - derive pointers in a consistent manner
 - remove superfluous data from prints and print statements that do not
   make sense

And change a couple of ints to bools, which isn't strictly print-related. :)


Signed-off-by: Matthew R. Ochs <mrochs@xxxxxxxxxxxxxxxxxx>

An impressive cleanup! Nothing bad which stands out to me.

Reviewed-by: Andrew Donnellan <andrew.donnellan@xxxxxxxxxxx>


--
Andrew Donnellan              OzLabs, ADL Canberra
andrew.donnellan@xxxxxxxxxxx  IBM Australia Limited

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux