----- Original Message ----- > From: "Bart Van Assche" <Bart.VanAssche@xxxxxxxxxxx> > To: "himanshu madhani" <himanshu.madhani@xxxxxxxxxx>, loberman@xxxxxxxxxx, nab@xxxxxxxxxxxxx > Cc: linux-scsi@xxxxxxxxxxxxxxx > Sent: Thursday, December 22, 2016 4:54:30 PM > Subject: Re: [PATCH ] tcm_qla2xxx - Enhancements to the tcm_debug jammer code to jam only data movement commands > > On Thu, 2016-12-22 at 16:46 -0500, Laurence Oberman wrote: > > Added the possibility of blocking only specific SCSI data movement commands > > but allowing TUR'S to pass. > > This has been helpful for debugging many driver/array interoperabilty > > issues. > > Hello Laurence, > > Your work is appreciated and also that you are posting this patch for > inclusion > in the kernel. However, since this is functionality of which I think that it > is > useful for all target drivers, shouldn't this kind of functionality be added > to > the target core instead of one specific target driver? > > Bart. Hello Bart Thank you for this. Indeed, That's on my plate for next year to try rework this into the target core. Its used a lot here at Red Hat for testing the F/C drivers and multipath via the LIO target server. The first version of this is already in that allows jamming of all commands. I wanted to share the enhancement which is very useful and has been working well here but indeed if we have this in the core its better. I may have some questions for you as I work on that next year. Many Thanks Bart for all your help this year. Regards Laurence -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
