> + while ((ha->tgt.atio_ring_ptr->signature != ATIO_PROCESSED) ||
> + FCPCMD_IS_CORRUPTED(ha->tgt.atio_ring_ptr)) {
No need for the inner braces.
> +#define FCPCMD_IS_CORRUPTED(_a) \
> + ((_a->entry_type == ATIO_TYPE7) && \
> + ((le16_to_cpu(_a->attr_n_length) & FCP_CMD_LENTH_MASK) < \
> + FCP_CMD_LENTH_MIN))
> +
> +/* adjust corrupted atio so we won't trip over the same entry again. */
> +#define ADJ_CORRUPTED_ATIO(_a) \
> +{ \
> + _a->u.raw.attr_n_length = cpu_to_le16(FCP_CMD_LENTH_MIN); \
> + ((struct atio_from_isp *)_a)->u.isp24.fcp_cmnd.add_cdb_len = 0; \
> +}
These should be inline functions instead of macros.
Otherwise looks fine:
Reviewed-by: Christoph Hellwig <hch@xxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
