Hi Bart, Christoph, On 12/15/16, 1:27 AM, "Bart Van Assche" <bart.vanassche@xxxxxxxxx> wrote: >On 12/14/2016 10:06 PM, Christoph Hellwig wrote: >> On Tue, Dec 06, 2016 at 12:30:43PM -0800, Himanshu Madhani wrote: >>> From: Quinn Tran <quinn.tran@xxxxxxxxxx> >>> >>> This patch adds capability to poll for an interrupt, If hardware >>> does not generate any interrupt for 2 seconds. >> >> This description sounds like the hardware might be buggy and not >> generate interrupts, in which case 2 seconds is a very long time. >> >> Can you explain the intention a bit better? > >In addition to Christoph's question: is this a workaround for a hardware >bug or for a firmware bug? If it is a workaround for a firmware bug, >since the qla2xxx firmware can be upgraded, why is an interrupt polling >mechanism added to the kernel driver instead of fixing the firmware? > >Bart. This issue was seen where we were debugging intermittent slow switch response related to cable pull in a small set of test environment. We thought it was a HW issue but turns out to be the switch. We left the patch in the test cycle to see if the problem re-occur and missed taking it out before submission. Since then we have not seen the problem re-occur. We’ll drop this patch from the series. Thanks, - Himanshu > ��.n��������+%������w��{.n�����{������ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f