Re: [PATCH v5 4/5] qla2xxx: Add Block Multi Queue functionality.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Dec 12, 2016 at 02:40:08PM -0800, Himanshu Madhani wrote:
> From: Michael Hernandez <michael.hernandez@xxxxxxxxxx>
> 
> Tell the SCSI layer how many hardware queues we have based on the number
> of max queue pairs created. The number of max queue pairs created will
> depend on number of MSI-X vector count.
> 
> This feature can be turned on via CONFIG_SCSI_MQ_DEFAULT or passing
> scsi_mod.use_blk_mq=Y as a parameter to the kernel

Looks fine,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

> +static int qla2xxx_map_queues(struct Scsi_Host *shost)
> +{
> +	scsi_qla_host_t *vha = (scsi_qla_host_t *)shost->hostdata;
> +
> +	return blk_mq_pci_map_queues(&shost->tag_set, vha->hw->pdev);
> +}

FYI, without the PCI_IRQ_AFFINITY flag this is useless, but also
harmless.  I'd suggest you send a patch to introduce irq-layer
affinity once we have that in mainline.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux