> -----Original Message----- > From: kushwaha.a@xxxxxxxxxxx [mailto:kushwaha.a@xxxxxxxxxxx] > Sent: Friday, December 09, 2016 5:18 AM > To: Don Brace; JBottomley@xxxxxxxx > Cc: linux-scsi@xxxxxxxxxxxxxxx; kushwaha.a@xxxxxxxxxxx; > d.wadhawan@xxxxxxxxxxx > Subject: [PATCH] scsi: hpsa: remove memory allocate failure message > > EXTERNAL EMAIL > > > From: Amit Kushwaha <kushwaha.a@xxxxxxxxxxx> > > This patch cleanup warning reported by checkpatch.pl > WARNING: Possible unnecessary 'out of memory' message > With no available memory, a warn on message already gets printed > by page alloc apis > > Signed-off-by: Amit Kushwaha <kushwaha.a@xxxxxxxxxxx> I notice that checkpatch reports other similar messages when run against the entire driver, which driver version did you run checkpatch on? Thanks, Don > --- > drivers/scsi/hpsa.c | 21 ++++++++------------- > 1 file changed, 8 insertions(+), 13 deletions(-) > > diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c > index 40669f8..bf14405 100644 > --- a/drivers/scsi/hpsa.c > +++ b/drivers/scsi/hpsa.c > @@ -1455,10 +1455,9 @@ static void hpsa_monitor_offline_device(struct > ctlr_info *h, > > /* Device is not on the list, add it. */ > device = kmalloc(sizeof(*device), GFP_KERNEL); > - if (!device) { > - dev_warn(&h->pdev->dev, "out of memory in %s\n", __func__); > + if (!device) > return; > - } > + > memcpy(device->scsi3addr, scsi3addr, sizeof(device->scsi3addr)); > spin_lock_irqsave(&h->offline_device_lock, flags); > list_add_tail(&device->offline_list, &h->offline_device_list); > @@ -1928,17 +1927,15 @@ static int hpsa_alloc_sg_chain_blocks(struct > ctlr_info *h) > > h->cmd_sg_list = kzalloc(sizeof(*h->cmd_sg_list) * h->nr_cmds, > GFP_KERNEL); > - if (!h->cmd_sg_list) { > - dev_err(&h->pdev->dev, "Failed to allocate SG list\n"); > + if (!h->cmd_sg_list) > return -ENOMEM; > - } > + > for (i = 0; i < h->nr_cmds; i++) { > h->cmd_sg_list[i] = kmalloc(sizeof(*h->cmd_sg_list[i]) * > h->chainsize, GFP_KERNEL); > - if (!h->cmd_sg_list[i]) { > - dev_err(&h->pdev->dev, "Failed to allocate cmd SG\n"); > + if (!h->cmd_sg_list[i]) > goto clean; > - } > + > } > return 0; > > @@ -3759,11 +3756,9 @@ static void hpsa_update_scsi_devices(struct > ctlr_info *h, int hostno) > } > > currentsd[i] = kzalloc(sizeof(*currentsd[i]), GFP_KERNEL); > - if (!currentsd[i]) { > - dev_warn(&h->pdev->dev, "out of memory at %s:%d\n", > - __FILE__, __LINE__); > + if (!currentsd[i]) > goto out; > - } > + > ndev_allocated++; > } > > -- > 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
