Hi Christoph,
On 12/7/16, 11:05 AM, "Christoph Hellwig" <hch@xxxxxxxxxxxxx> wrote:
>On Tue, Dec 06, 2016 at 11:07:44AM -0800, Himanshu Madhani wrote:
>> From: Michael Hernandez <michael.hernandez@xxxxxxxxxx>
>>
>> Replaced existing multiple queue functionality with framework
>> that allows for the creation of pairs of request and response queues,
>> either at start of day or dynamically.
>>
>> Queue pair creation depend on module parameter "ql2xmqsupport",
>> which need to be enabled to create queue pair.
>
>This doesn't seem to address any of the feedback from the last
>round of feedback, was is sent out before that?
Following changes are incorporated into current patch
- Merged code from new files into existing code
- Enabled multi queue support by default.
- Update to use kcalloc instead of kzalloc.
Following review comments are not addressed as part of this patch
- Using bits-ops instead of uint32_t.
- Converting macros into inline function.
- Fixing the vref counting in the driver.
- Using wait queue instead of busy wait.
- Remove driver allocated mempools for SRB and use the one passed in via command.
These changes are going to need us to run regression tests and would take bit longer.
Would you be willing to accept this patch and we will post updates as new patch later.
Thanks,
- Himanshu
��.n��������+%������w��{.n�����{������ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
