On Sat, 10 Jun 2006, Christoph Hellwig wrote: > On Sat, Jun 10, 2006 at 03:29:58PM +0200, Guennadi Liakhovetski wrote: > > > > hmm I wonder if the non-use-sg case can ever happen? > > > > (and if that irq_save isn't leaking here) > > > > > > It can still happen in when invoked through the EH code, but I plan to fix > > > that for 2.6.18. > > > > "can happen" - you mean INQUIRY without sg (NOT irq_save leaking)? > > Oh, that's a path only reached for INQUIRY commands. No, there is no > chance to get non-sg commands for 2.6.17+ Is the plan to completely remove non-sg commands from scsi? Then, I guess, at some point use_sg + void *request_buffer will be replaced with a sg_count + struct scatterlist *request_gs. Would it be better to keep the use_sg == 0 test in until then? Or shall I resubmit the patch without that check or with a BUG_ON(!use_sg)? Thanks Guennadi --- Guennadi Liakhovetski - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
