On Fri, Nov 25, 2016 at 12:53:17PM +0100, Johannes Thumshirn wrote: > On Fri, Nov 25, 2016 at 01:20:34PM +0200, Eyal Ben David wrote: > > Note that sg_mmap_read does not parse the SCSI sense, so the script > > might fail for other reasons (some SCSI error) and think its a zero > > byte corruption. > > But SCSI generic checks for errors and returns -EINVAL on CHECK_CONDITION or > DRIVER_SENSE (and sets SG_INFO_CHECK in hdr.info). > > And: > VM:~ # ./test.sh > FAIL on run 2 > Expect: > 0000000 8240 3d1f 8800 ffff 0002 0000 0000 0000 > 0000020 0000 0000 0000 0000 6e9d 57ac 0000 0000 > 0000040 0000 0000 0000 0000 0000 0000 0000 0000 > * > 0000100 > Fail: > 0000000 0000 0000 0000 0000 0000 0000 0000 0000 > * > 0000100 > VM:~ # uname -r > 4.8.9-60-default+ > VM:~ # > > > Anyways, can you test the patch Ewan found on one of your kernel's that are > known to fail? Hannes found another interesting aspect, if one sets the allow_dio module parameter to one and sets the SG_FLAG_DIRECT_IO in the header, it works reliably. Byte, Johannes -- Johannes Thumshirn Storage jthumshirn@xxxxxxx +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850 -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html