On Mon, Nov 21, 2016 at 03:04:28PM +0100, Martin Wilck wrote: > When the hpsa module is unloaded using rmmod, dangling > symlinks remain under /sys/class/sas_phy. Fix this by > calling sas_phy_delete() rather than sas_phy_free (which, > according to comments, should not be called for PHYs that > have been set up successfully, anyway). > > References: bsc#1010946. I don't think the SUSE bugzilla tag is of relevance upstream. But for sake of completeness we could add a Link: https://bugzilla.suse.com/show_bug.cgi?id=1010946 > Signed-off-by: Martin Wilck <mwilck@xxxxxxx> Reviewed-by: Johannes Thumshirn <jthumshirn@xxxxxxx> > --- > drivers/scsi/hpsa.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c > index efe2f36..8ec77c3 100644 > --- a/drivers/scsi/hpsa.c > +++ b/drivers/scsi/hpsa.c > @@ -9547,9 +9547,9 @@ static void hpsa_free_sas_phy(struct hpsa_sas_phy *hpsa_sas_phy) > struct sas_phy *phy = hpsa_sas_phy->phy; > > sas_port_delete_phy(hpsa_sas_phy->parent_port->port, phy); > - sas_phy_free(phy); > if (hpsa_sas_phy->added_to_port) > list_del(&hpsa_sas_phy->phy_list_entry); > + sas_phy_delete(phy); > kfree(hpsa_sas_phy); > } > > -- > 2.10.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Johannes Thumshirn Storage jthumshirn@xxxxxxx +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850 -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
