Ok, got it. I will resend a new patch. On Tue, Nov 15, 2016 at 11:00:12AM -0800, Subhash Jadavani wrote: > On 2016-11-15 04:25, Zang Leigang wrote: > >We set ufshcd_state to UFSHCD_STATE_ERROR when an err handler > >fails. So I think UFSHCD_STATE_ERROR means host not works any more. > >Set it before schedule eh_work is not correct. > > > >Signed-off-by: Zang Leigang <zangleigang@xxxxxxxxxxxxx> > > > >diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c > >index 05c7456..a7724ad 100644 > >--- a/drivers/scsi/ufs/ufshcd.c > >+++ b/drivers/scsi/ufs/ufshcd.c > >@@ -4158,7 +4158,6 @@ static void ufshcd_check_errors(struct > >ufs_hba *hba) > > /* block commands from scsi mid-layer */ > > scsi_block_requests(hba->host); > > > >- hba->ufshcd_state = UFSHCD_STATE_ERROR; > > But we may still want to stop the new requests from being issued > (via ufshcd_queuecommand) until error handler (ufshcd_err_handler()) > gets chance to run. May be a new intermediate state like > UFSHCD_STATE_EH_SCHEDULED should be added and set here, we have to > check the same in ufshcd_queuecommand() to return busy if > ufshcd_state is UFSHCD_STATE_EH_SCHEDULED. > > > schedule_work(&hba->eh_work); > > } > > } > > -- > The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, > a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
