Are you sure of this? The code that follows expects the end of the structure to be cleared. Sincerely -- Mark Salyzyn > -----Original Message----- > From: Christoph Hellwig [mailto:hch@xxxxxxxxxxxxx] > Sent: Thursday, June 08, 2006 4:11 PM > To: Mark Haverkamp > Cc: James Bottomley; linux-scsi; Salyzyn, Mark > Subject: Re: [PATCH 1/3] aacraid: Fix return code interpretation > > > > @@ -564,7 +564,7 @@ > > > > f = compat_alloc_user_space(sizeof(*f)); > > ret = 0; > > - if (clear_user(f, sizeof(*f)) != sizeof(*f)) > > + if (clear_user(f, sizeof(*f))) > > ret = -EFAULT; > > if (copy_in_user(f, (void __user *)arg, > sizeof(struct fib_ioctl) - sizeof(u32))) > > ret = -EFAULT; > > > > just remove the clear_user call completely, it's not needed. > > - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
