On 11/08/2016 05:20 PM, Kashyap Desai wrote:
-----Original Message-----
From: Martin K. Petersen [mailto:martin.petersen@xxxxxxxxxx]
Sent: Wednesday, November 09, 2016 4:45 AM
To: Jens Axboe
Cc: linux-scsi; Kashyap Desai; Martin K. Petersen
Subject: Re: [REGRESSION] 4.9-rc4+ doesn't boot on my test box
"Jens" == Jens Axboe <axboe@xxxxxxxxx> writes:
Jens> I wasted half a day on this, thinking it was something in my
Jens> 4.10 branches. But it turns out it is not, the regression is in
Jens> mainline.
Jens -
Sorry for trouble. I did not validated this single patch. I validated
complete patch set.
Issue is improper MACRO usage MEGASAS_IS_LOGICAL, which gives incorrect
check condition in qcmd Path.
Below is proposed fix.
diff --git a/drivers/scsi/megaraid/megaraid_sas.h
b/drivers/scsi/megaraid/megaraid_sas.h
index 74c7b44..0d2625b 100644
--- a/drivers/scsi/megaraid/megaraid_sas.h
+++ b/drivers/scsi/megaraid/megaraid_sas.h
@@ -2236,7 +2236,7 @@ struct megasas_instance_template {
};
#define MEGASAS_IS_LOGICAL(scp)
\
- (scp->device->channel < MEGASAS_MAX_PD_CHANNELS) ? 0 : 1
Ugh... So we're completing everything immediately.
Martin - I validated whole series. Apologies for this.
Please help me to know how to fix this ? Do I need to send only fix on top
of latest commit (as posted above - MACRO definition) for this issue ?
Send a fix on top of current -git asap. The current tree is completely
broken for any megaraid user. -rc4 is no time to send in untested
patches, especially not something that claims to fix a 9 year old bug
and is marked for stable as well.
--
Jens Axboe
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
