On Mon, Nov 07, 2016 at 05:31:03PM +0100, Thomas Gleixner wrote: > On Mon, 7 Nov 2016, Christoph Hellwig wrote: > > > It seems like the whole damn driver should just use threaded interrupts. > > Of course it's a giant beast and not just the iSCSI one. But even > > if we don't go all the way I'd much prefer workqueues. kthread work > > is simply the worst API ever and I'd prefer to not have it proliferate. > > That's what the patch is doing. It uses INIT_WORK() and > schedule_work[_on](). I can't find any reference to kthread work. You're right it does - between the incorrect subject and the fact that it still keeps the linked list of items arounds instead of fully using the workqueue infrastructure I was a bit confused before my first coffee this morning. Same applies to patch 2. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html