Re: [PATCH 2/3] scsi_dh_emc: switch to scsi_execute_req_flags()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Hannes,

[auto build test WARNING on scsi/for-next]
[also build test WARNING on v4.9-rc3 next-20161028]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Hannes-Reinecke/scsi_dh-switch-to-scsi_execute_req_flags/20161103-212623
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next
config: i386-randconfig-x014-201644 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All warnings (new ones prefixed by >>):

   drivers/scsi/device_handler/scsi_dh_emc.c: In function 'trespass_endio':
>> drivers/scsi/device_handler/scsi_dh_emc.c:133:61: warning: statement with no effect [-Wunused-value]
     } else if (sshdr->sense_key == 0x02 && sshdr->asc == 0x04) &&
                                                                ^~
         sshdr->ascq == 0x03) {
         ~~~~~                                                   
   drivers/scsi/device_handler/scsi_dh_emc.c:134:11: error: expected ';' before '->' token
         sshdr->ascq == 0x03) {
              ^~
   drivers/scsi/device_handler/scsi_dh_emc.c:134:25: error: expected statement before ')' token
         sshdr->ascq == 0x03) {
                            ^
   drivers/scsi/device_handler/scsi_dh_emc.c:143:4: error: 'else' without a previous 'if'
     } else
       ^~~~
   drivers/scsi/device_handler/scsi_dh_emc.c:134:6: error: label 'sshdr' used but not defined
         sshdr->ascq == 0x03) {
         ^~~~~

vim +133 drivers/scsi/device_handler/scsi_dh_emc.c

   117	
   118		sdev_printk(KERN_ERR, sdev, "%s: Found valid sense data 0x%2x, "
   119			    "0x%2x, 0x%2x while sending CLARiiON trespass "
   120			    "command.\n", CLARIION_NAME, sshdr->sense_key,
   121			    sshdr->asc, sshdr->ascq);
   122	
   123		if (sshdr->sense_key == 0x05 && sshdr->asc == 0x04 &&
   124		    sshdr->ascq == 0x00) {
   125			/*
   126			 * Array based copy in progress -- do not send
   127			 * mode_select or copy will be aborted mid-stream.
   128			 */
   129			sdev_printk(KERN_INFO, sdev, "%s: Array Based Copy in "
   130				    "progress while sending CLARiiON trespass "
   131				    "command.\n", CLARIION_NAME);
   132			err = SCSI_DH_DEV_TEMP_BUSY;
 > 133		} else if (sshdr->sense_key == 0x02 && sshdr->asc == 0x04) &&
   134			   sshdr->ascq == 0x03) {
   135			/*
   136			 * LUN Not Ready - Manual Intervention Required
   137			 * indicates in-progress ucode upgrade (NDU).
   138			 */
   139			sdev_printk(KERN_INFO, sdev, "%s: Detected in-progress "
   140				    "ucode upgrade NDU operation while sending "
   141				    "CLARiiON trespass command.\n", CLARIION_NAME);

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux