On 11/02/2016 04:06 PM, Christoph Hellwig wrote:
On Tue, Nov 01, 2016 at 10:49:36PM +0100, Hannes Reinecke wrote:
Switch to scsi_execute_req_flags() instead of
using the block interface directly. This will set
REQ_QUIET and REQ_PREEMPT, but this is okay as
we're evaluating the errors anyway and should be
able to send the command even if the device is
quiesced.
Actually most users are switched to scsi_get_vpd_page if I read the patch
right, which is even better. And it seems like the remaining user of
scsi_execute_req_flags could be switch to use scsi_mode_select() as well,
but maybe we should leave that out for now.
I'd rather not do that now, as switching to scsi_mode_select() would
cause the failfast flags to be lost, and I'll have to think about the
implications of doing so.
+ if (scsi_execute_req_flags(sdev, cdb, DMA_TO_DEVICE,
+ &h->ctlr->mode_select, data_size, &sshdr,
+ RDAC_TIMEOUT * HZ,
+ RDAC_RETRIES, NULL, REQ_FAILFAST_MASK)) {
Pleae use the individual failfast flags - REQ_FAILFAST_MASK is just
for block layer use.
Okay.
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@xxxxxxx +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
