On Tue, Nov 01, 2016 at 10:49:37PM +0100, Hannes Reinecke wrote: > Switch to scsi_execute_req_flags() instead of > using the block interface directly. This will set ... and scsi_get_vpd_page() > + if ((sshdr->sense_key == 0x05) && (sshdr->asc == 0x04) && > + (sshdr->ascq == 0x00)) { > + } else if ((sshdr->sense_key == 0x02) && (sshdr->asc == 0x04) && > + (sshdr->ascq == 0x03)) { No need for the inner braces. Otherwise looks fine: Reviewed-by: Christoph Hellwig <hch@xxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html