>>>>> "Bart" == Bart Van Assche <bart.vanassche@xxxxxxxxxxx> writes: Bart> The code at the end of alua_rtpg_work() is as follows: Bart> scsi_device_put(sdev); Bart> kref_put(&pg->kref, release_port_group); Bart> In other words, alua_rtpg_queue() must hold an sdev reference and Bart> a pg reference before queueing rtpg work. If no rtpg work is Bart> queued no additional references should be held when Bart> alua_rtpg_queue() returns. If no rtpg work is queued, ensure that Bart> alua_rtpg_queue() only gives up the sdev reference if that Bart> reference was obtained by the same alua_rtpg_queue() call. Applied to 4.9/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html