> -----Original Message----- > From: Christoph Hellwig [mailto:hch@xxxxxxxxxxxxx] > Sent: Thursday, October 27, 2016 10:19 AM > To: Don Brace > Cc: jejb@xxxxxxxxxxxxxxxxxx; John Hall; Kevin Barnett; Mahesh > Rajashekhara; hch@xxxxxxxxxxxxx; Scott Teel; Viswas G; Justin Lindley; Scott > Benesh; elliott@xxxxxxx; POSWALD@xxxxxxxx; linux-scsi@xxxxxxxxxxxxxxx > Subject: Re: [PATCH 1/4] hpsa: correct lockup detector pci_disable_device > > EXTERNAL EMAIL > > > > - pci_disable_device(h->pdev); > > + if (pci_is_enabled(h->pdev)) > > + pci_disable_device(h->pdev); > > fail_all_outstanding_cmds(h); > > Humm. How can this even happen when the device isn't enabled? controller_lockup_detected can be called multiple times, especially when I am exercising the reset handler and abort handler, so I wanted to avoid the kernel warning messages. fail_all_outstanding_commands is called with status CMD_CTLR_LOCKUP and complete_scsi_command returns DID_NO_CONNECT. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
