On 10/27/2016 02:46 AM, Johannes Thumshirn wrote:
On Wed, Oct 26, 2016 at 11:44:51AM -0700, Bart Van Assche wrote:
+static void scsi_remove_device_async(struct scsi_device *sdev)
+{
+ if (scsi_device_get(sdev) < 0)
Nit: the < 0 could be dropped, scsi_device_get returns either -ENXIO or
0. But no reason to respin.
Anyways,
Reviewed-by: Johannes Thumshirn <jthumshirn@xxxxxxx>
Hello Johannes,
Thanks for the review. But I'd like to clarify that I added the "< 0" on
purpose. Some *_get*() functions in the Linux kernel return 0 upon
failure (e.g. kref_get_unless_zero()) and others a negative value (e.g.
scsi_device_get()). The "< 0" part avoids that someone who reads this
code has to look up what return value convention scsi_device_get() uses.
Bart.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
