Re: [PATCH] fix up request buffer reference in various scsi drivers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jun 08, 2006 at 07:37:14AM -0400, Jeff Garzik wrote:
> Christoph Hellwig wrote:
> >Various scsi drivers use scsi_cmnd.buffer and scsi_cmnd.bufflen in their
> >queuecommand functions.  Those fields are internal storage for the
> >midlayer only and are used to restore the original payload after
> >request_buffer and request_bufflen have been overwritten for EH.  Using
> >the buffer and bufflen fields means they do very broken things in error
> >handling.
> 
> False statement, for libata.

Why?  I don't see anywhere in libata where it touches ->buffer or
->bufflen other than the two cases Christoph removed.
-
: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux