On Fri, 2016-10-21 at 14:10 -0700, Chris Leech wrote:
> With the error message I added in "libfc: sanity check cpu number
> extracted from xid" I didn't account for the fact that fc_exch_find is
> called with FC_XID_UNKNOWN at the start of a new exchange if we are the
> responder.
>
> It doesn't come up with the initiator much, but that's basically every
> exchange for a target. By checking the xid for FC_XID_UNKNOWN first, we
> not only prevent the erroneous error message, but skip the unnecessary
> lookup attempt as well.
>
> Signed-off-by: Chris Leech <cleech@xxxxxxxxxx>
> ---
> drivers/scsi/libfc/fc_exch.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/scsi/libfc/fc_exch.c b/drivers/scsi/libfc/fc_exch.c
> index 16ca31a..42cc403 100644
> --- a/drivers/scsi/libfc/fc_exch.c
> +++ b/drivers/scsi/libfc/fc_exch.c
> @@ -910,6 +910,9 @@ static struct fc_exch *fc_exch_find(struct fc_exch_mgr *mp, u16 xid)
> struct fc_exch *ep = NULL;
> u16 cpu = xid & fc_cpu_mask;
>
> + if (xid == FC_XID_UNKNOWN)
> + return NULL;
> +
> if (cpu >= nr_cpu_ids || !cpu_possible(cpu)) {
> printk_ratelimited(KERN_ERR
> "libfc: lookup request for XID = %d, "
Reviewed-by: Ewan D. Milne <emilne@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
