Re: [PATCH 2/7] megaraid_sas: Send correct PhysArm to FW for R1 VD downgrade

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/17/2016 12:24 PM, Sumit Saxena wrote:
> This patch fixes the issue of wrong PhysArm was sent to firmware for R1
> VD downgrade.
> 
> Signed-off-by: Kiran Kumar Kasturi <kiran-kumar.kasturi@xxxxxxxxxxxx>
> Signed-off-by: Sumit Saxena <sumit.saxena@xxxxxxxxxxxx>
> ---
>  drivers/scsi/megaraid/megaraid_sas_fp.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/scsi/megaraid/megaraid_sas_fp.c b/drivers/scsi/megaraid/megaraid_sas_fp.c
> index e413113..f237d00 100644
> --- a/drivers/scsi/megaraid/megaraid_sas_fp.c
> +++ b/drivers/scsi/megaraid/megaraid_sas_fp.c
> @@ -782,7 +782,8 @@ static u8 mr_spanset_get_phy_params(struct megasas_instance *instance, u32 ld,
>  			(raid->regTypeReqOnRead != REGION_TYPE_UNUSED))))
>  			pRAID_Context->regLockFlags = REGION_TYPE_EXCLUSIVE;
>  		else if (raid->level == 1) {
> -			pd = MR_ArPdGet(arRef, physArm + 1, map);
> +			physArm = physArm + 1;
> +			pd = MR_ArPdGet(arRef, physArm, map);
>  			if (pd != MR_PD_INVALID)
>  				*pDevHandle = MR_PdDevHandleGet(pd, map);
>  		}
> @@ -879,7 +880,8 @@ u8 MR_GetPhyParams(struct megasas_instance *instance, u32 ld, u64 stripRow,
>  			pRAID_Context->regLockFlags = REGION_TYPE_EXCLUSIVE;
>  		else if (raid->level == 1) {
>  			/* Get alternate Pd. */
> -			pd = MR_ArPdGet(arRef, physArm + 1, map);
> +			physArm = physArm + 1;
> +			pd = MR_ArPdGet(arRef, physArm, map);
>  			if (pd != MR_PD_INVALID)
>  				/* Get dev handle from Pd */
>  				*pDevHandle = MR_PdDevHandleGet(pd, map);
> 
Reviewed-by: Hannes Reinecke <hare@xxxxxxxx>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		   Teamlead Storage & Networking
hare@xxxxxxx			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux