Re: [PATCH v3 06/17] lpfc: Code clean up for lpfc_iocb_cnt parameter

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/14/2016 12:06 AM, James Smart wrote:
> 
> Code clean up for lpfc_iocb_cnt parameter
> 
> Signed-off-by: Dick Kennedy <dick.kennedy@xxxxxxxxxxxx>
> Signed-off-by: James Smart <james.smart@xxxxxxxxxxxx>
> Reviewed-by: Johannes Thumshirn <jthumshirn@xxxxxxx>
> ---
>  drivers/scsi/lpfc/lpfc_attr.c | 8 +-------
>  1 file changed, 1 insertion(+), 7 deletions(-)
> 
> diff --git a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc/lpfc_attr.c
> index be81e61..e5092dc 100644
> --- a/drivers/scsi/lpfc/lpfc_attr.c
> +++ b/drivers/scsi/lpfc/lpfc_attr.c
> @@ -2827,14 +2827,8 @@ lpfc_txcmplq_hw_show(struct device *dev, struct device_attribute *attr,
>  static DEVICE_ATTR(txcmplq_hw, S_IRUGO,
>  			 lpfc_txcmplq_hw_show, NULL);
>  
> -int lpfc_iocb_cnt = 2;
> -module_param(lpfc_iocb_cnt, int, S_IRUGO);
> -MODULE_PARM_DESC(lpfc_iocb_cnt,
> +LPFC_ATTR_R(iocb_cnt, 2, 1, 5,
>  	"Number of IOCBs alloc for ELS, CT, and ABTS: 1k to 5k IOCBs");
> -lpfc_param_show(iocb_cnt);
> -lpfc_param_init(iocb_cnt, 2, 1, 5);
> -static DEVICE_ATTR(lpfc_iocb_cnt, S_IRUGO,
> -			 lpfc_iocb_cnt_show, NULL);
>  
>  /*
>  # lpfc_nodev_tmo: If set, it will hold all I/O errors on devices that disappear
> 
Reviewed-by: Hannes Reinecke <hare@xxxxxxxx>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		   Teamlead Storage & Networking
hare@xxxxxxx			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux