On 10/12/2016 03:06 PM, Johannes Thumshirn wrote: > Don't set FC_RQST_STATE_DONE before calling fc_bsg_jobdone() as > fc_bsg_jobdone() calls blk_complete_requeust() which raises a soft-IRQ that > ends up in fc_bsg_sofirq_done() and fc_bsg_softirq_done() sets the > FC_RQST_STATE_DONE flag. > > Signed-off-by: Johannes Thumshirn <jthumshirn@xxxxxxx> > --- > drivers/scsi/libfc/fc_lport.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/scsi/libfc/fc_lport.c b/drivers/scsi/libfc/fc_lport.c > index 156708a..53d13721 100644 > --- a/drivers/scsi/libfc/fc_lport.c > +++ b/drivers/scsi/libfc/fc_lport.c > @@ -1911,7 +1911,6 @@ static void fc_lport_bsg_resp(struct fc_seq *sp, struct fc_frame *fp, > bsg_reply->result = (PTR_ERR(fp) == -FC_EX_CLOSED) ? > -ECONNABORTED : -ETIMEDOUT; > job->reply_len = sizeof(uint32_t); > - job->state_flags |= FC_RQST_STATE_DONE; > fc_bsg_jobdone(job, bsg_reply->result, > bsg_reply->reply_payload_rcv_len); > kfree(info); > @@ -1947,7 +1946,6 @@ static void fc_lport_bsg_resp(struct fc_seq *sp, struct fc_frame *fp, > bsg_reply->reply_payload_rcv_len = > job->reply_payload.payload_len; > bsg_reply->result = 0; > - job->state_flags |= FC_RQST_STATE_DONE; > fc_bsg_jobdone(job, bsg_reply->result, > bsg_reply->reply_payload_rcv_len); > kfree(info); > Reviewed-by: Hannes Reinecke <hare@xxxxxxxx> Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@xxxxxxx +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
