Re: [PATCH 2/7] libfc: Fixup disc_mutex handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Sep 30, 2016 at 09:04:09AM +0200, Hannes Reinecke wrote:
> The list of attached 'rdata' remote port structures is RCU
> protected, so there is no need to take the 'disc_mutex' when
> traversing it.
> Rather we should be using rcu_read_lock() and kref_get_unless_zero()
> to validate the entries.
> We need, however, take the disc_mutex when deleting an entry;
> otherwise we risk clashes with list_add.
> 
> Signed-off-by: Hannes Reinecke <hare@xxxxxxxx>
> ---

Acked-by: Johannes Thumshirn <jth@xxxxxxxxxx>

-- 
Johannes Thumshirn                                          Storage
jthumshirn@xxxxxxx                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux