Reviewed-by: Kiwoong Kim <kwmad.kim@xxxxxxxxxxx> > -----Original Message----- > From: linux-scsi-owner@xxxxxxxxxxxxxxx [mailto:linux-scsi- > owner@xxxxxxxxxxxxxxx] On Behalf Of subhashj@xxxxxxxxxxxxxx > Sent: Thursday, September 29, 2016 7:50 AM > To: Wei Yongjun > Cc: Vinayak Holikatti; James E.J. Bottomley; Martin K. Petersen; Wei > Yongjun; linux-scsi@xxxxxxxxxxxxxxx; linux-scsi-owner@xxxxxxxxxxxxxxx > Subject: Re: [PATCH -next] scsi: ufs: fix error return code in > ufshcd_init() > > Looks good to me. > Reviewed-by: Subhash Jadavani <subhashj@xxxxxxxxxxxxxx> > > On 2016-09-28 07:49, Wei Yongjun wrote: > > From: Wei Yongjun <weiyongjun1@xxxxxxxxxx> > > > > Fix to return a negative error code from the error handling case > > instead of 0, as done elsewhere in this function. > > > > Signed-off-by: Wei Yongjun <weiyongjun1@xxxxxxxxxx> > > --- > > drivers/scsi/ufs/ufshcd.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c > > index 37f3c51..6aebb7e 100644 > > --- a/drivers/scsi/ufs/ufshcd.c > > +++ b/drivers/scsi/ufs/ufshcd.c > > @@ -6500,6 +6500,7 @@ int ufshcd_init(struct ufs_hba *hba, void > > __iomem *mmio_base, unsigned int irq) > > if (IS_ERR(hba->devfreq)) { > > dev_err(hba->dev, "Unable to register with > devfreq %ld\n", > > PTR_ERR(hba->devfreq)); > > + err = PTR_ERR(hba->devfreq); > > goto out_remove_scsi_host; > > } > > /* Suspend devfreq until the UFS device is detected */ > > > > > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-scsi" > > in > > the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info > > at http://vger.kernel.org/majordomo-info.html > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at > http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
