Hi, Martin. I think that the patch is correct. UFS spec says "The Data Segment area is empty" for Read Descriptor. I have been using similar code with it and it works. That have been already applied in Android kernel. Reviewed-by: Kiwoong Kim <kwmad.kim@xxxxxxxxxxx> Regards. > -----Original Message----- > From: linux-scsi-owner@xxxxxxxxxxxxxxx [mailto:linux-scsi- > owner@xxxxxxxxxxxxxxx] On Behalf Of Martin K. Petersen > Sent: Wednesday, September 28, 2016 2:14 PM > To: subhashj@xxxxxxxxxxxxxx > Cc: Zang Leigang; vinholikatti@xxxxxxxxx; jejb@xxxxxxxxxxxxxxxxxx; > martin.petersen@xxxxxxxxxx; linux-scsi@xxxxxxxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx; linux-scsi-owner@xxxxxxxxxxxxxxx > Subject: Re: [PATCH v2] UFS: Date Segment only need for WRITE DESCRIPTOR > > >>>>> "Subhash" == subhashj <subhashj@xxxxxxxxxxxxxx> writes: > > Subhash> Looks good to me. > > > - /* Data segment length */ > > - ucd_req_ptr->header.dword_2 = UPIU_HEADER_DWORD( > > - 0, 0, len >> 8, (u8)len); > > + /* Data segment length only need for WRITE_DESC */ > > + if (query->request.upiu_req.opcode == UPIU_QUERY_OPCODE_WRITE_DESC) > > + ucd_req_ptr->header.dword_2 = > > + UPIU_HEADER_DWORD(0, 0, (len >> 8), (u8)len); > > + else > > + ucd_req_ptr->header.dword_2 = 0; > > What about READ_DESC? > > -- > Martin K. Petersen Oracle Linux Engineering > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at > http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
