Hi,
Thursday, May 25, 2006 12:46 PM, Randy Dunlap wrote:
> Fix section warning:
> WARNING: drivers/scsi/megaraid/megaraid_mbox.o - Section
> mismatch: reference to .init.text: from .text between
> 'megaraid_probe_one' (at offset 0x171e) and 'megaraid_queue_command'
>
> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxx>
> ---
> drivers/scsi/megaraid/megaraid_mbox.c | 2 +-
> 1 files changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-2617-rc5.orig/drivers/scsi/megaraid/megaraid_mbox.c
> +++ linux-2617-rc5/drivers/scsi/megaraid/megaraid_mbox.c
> @@ -714,7 +714,7 @@ megaraid_io_detach(adapter_t *adapter)
> * . Allocate memory required for all the commands
> * . Use internal library of FW routines, build up complete
> soft state
> */
> -static int __init
> +static int __devinit
> megaraid_init_mbox(adapter_t *adapter)
> {
> struct pci_dev *pdev;
Thank you for pointing out a bug.
However, in my opinion, I would rather to simply remove '__init' from the function.
The function is just a sub function called by megaraid_probe_one which has '__devinit' tag.
Please let me know if this is acceptable.
I will submit a patch with proper change.
Thanks,
Seokmann
> -----Original Message-----
> From: linux-scsi-owner@xxxxxxxxxxxxxxx
> [mailto:linux-scsi-owner@xxxxxxxxxxxxxxx] On Behalf Of Randy.Dunlap
> Sent: Thursday, May 25, 2006 12:46 PM
> To: __smail Dönmez; scsi
> Cc: akpm; jejb; Kolli, Neela
> Subject: [PATCH] megaraid_mbox: fix section mismatch warnings
>
> From: Randy Dunlap <rdunlap@xxxxxxxxxxxx>
>
> Fix section warning:
> WARNING: drivers/scsi/megaraid/megaraid_mbox.o - Section
> mismatch: reference to .init.text: from .text between
> 'megaraid_probe_one' (at offset 0x171e) and 'megaraid_queue_command'
>
> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxx>
> ---
> drivers/scsi/megaraid/megaraid_mbox.c | 2 +-
> 1 files changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-2617-rc5.orig/drivers/scsi/megaraid/megaraid_mbox.c
> +++ linux-2617-rc5/drivers/scsi/megaraid/megaraid_mbox.c
> @@ -714,7 +714,7 @@ megaraid_io_detach(adapter_t *adapter)
> * . Allocate memory required for all the commands
> * . Use internal library of FW routines, build up complete
> soft state
> */
> -static int __init
> +static int __devinit
> megaraid_init_mbox(adapter_t *adapter)
> {
> struct pci_dev *pdev;
>
>
> ---
> -
> : send the line "unsubscribe
> linux-scsi" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
-
: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
