Re: [PATCH] dpt_i2o underflow check (Was: dpt_i2o and sd driver's problem)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Dear Mark,

Thank you.
I appreciate your quick response.

Best Regards
Hiroomi Sakurai

"Salyzyn, Mark" <mark_salyzyn@xxxxxxxxxxx> wrote:

> I agree, the math for underflow is flawed for block sizes other than
> 512, but I leave it up to the community to decide if there is some
> history behind this decision. This math has remained this way 'forever'.
> 
> The dpt_i2o driver should have the following (and more accurately
> enclosed) patch to match up with what other sections of code in this
> driver are doing with regards to the underflow check. Other drivers all
> appear to be performing the underflow check in this manner.
> 
>          len = cmd->request_bufflen;
> 
> -        if(cmd->underflow && len != cmd->underflow){
> +        if(cmd->underflow && len < cmd->underflow){
>                  printk(KERN_WARNING"Cmd len %08X Cmd underflow %08X\n",
>                          len, cmd->underflow);
>          }
> 
> Sincerely -- Mark Salyzyn
> 


-
: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux