On Mon, 2006-05-15 at 13:08 -0400, Jeff Garzik wrote: > linux-scsi should have been included in the CC. Yes, it should, thanks. It's a pretty huge change, so I haven't gone over it all. However, two things leap to mind immediately about this patch set 1) your host_eh_scheduled logic looks wrong. It seems to me that you can miss the wakeup if the host is busy? I also don't see a need to move the prototype out of scsi_priv.h ... it should only be used by transport classes, anyway. 2) This scsi_req_abort_cmd() is fundamentally the wrong logic. Everything else is communicated back as a result code from the command in done(). This should be no different ... A status return of DID_FAILED which scsi_decide_disposition() always translates to FAILED would seem to do exactly what you want without all the overhead. I'll find time to go over the rest of this later ... James - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
